-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump dependency for code-cover-pubish
GH action
#137298
Merged
craig
merged 1 commit into
cockroachdb:master
from
srosenberg:sr/code_cover_publish_bump
Dec 11, 2024
Merged
ci: bump dependency for code-cover-pubish
GH action
#137298
craig
merged 1 commit into
cockroachdb:master
from
srosenberg:sr/code_cover_publish_bump
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to make no difference? https://github.com/cockroachdb/cockroach/actions/runs/12284311045 |
srosenberg
force-pushed
the
sr/code_cover_publish_bump
branch
from
December 11, 2024 20:28
2da0abc
to
6000bf4
Compare
rickystewart
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, I forgot that the workflow runs from master
, so you need to merge this to see if it works.
RaduBerinde
approved these changes
Dec 11, 2024
`actions/github-script` started failing auth on `downloadArtifact` as of several weeks ago. Bumping to the latest version (v7.0.1) seems to resolve it. Epic: none Release note: None
srosenberg
force-pushed
the
sr/code_cover_publish_bump
branch
from
December 11, 2024 22:35
6000bf4
to
975c428
Compare
TFTR! bors r=rickystewart,RaduBerinde |
golgeek
added a commit
to golgeek/cockroach
that referenced
this pull request
Dec 13, 2024
Before the fix provided byn cockroachdb#137298, this Github Action was silently failing. This PR configures a call to DeadManSnitch service to report when the Github Action was last successful. The service is configured to alert CRL internal team when no ping was seen in the last 24h. Epic: none Release note: None Signed-off-by: Ludovic Leroux <[email protected]>
golgeek
added a commit
to golgeek/cockroach
that referenced
this pull request
Dec 13, 2024
Before the fix provided by cockroachdb#137298, this Github Action was silently failing. This PR configures a call to DeadManSnitch service to report when the Github Action was last successful. The service is configured to alert CRL internal team when no ping was seen in the last 24h. Epic: none Release note: None Signed-off-by: Ludovic Leroux <[email protected]>
craig bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
137412: ci: deadmansnitch for code-cover-publish Github Action r=srosenberg,rickystewart,DarrylWong a=golgeek Before the fix provided by #137298, this Github Action was silently failing. This PR configures a call to DeadManSnitch service to report when the Github Action was last successful. The service is configured to alert CRL internal team when no ping was seen in the last 24h. Epic: none Release note: None Co-authored-by: Ludovic Leroux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/github-script
started failing auth ondownloadArtifact
as of several weeks ago. Bumping to the latest version (v7.0.1)
seems to resolve it.
Epic: none
Release note: None